Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [RFC] Looking for opinions on accepting refactoring patches
- X-seq: zsh-workers 42476
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
- Subject: Re: [RFC] Looking for opinions on accepting refactoring patches
- Date: Sat, 17 Mar 2018 16:39:08 -0700
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=9mkYBFFneIDlRt1ICPeVUvb+XO7bsLmudYnIuvjtXZg=; b=QTBcDcN4QjH92D/14YJBKLae0ic5jjA4OcKfO3dn5b4i/y6tyOxTvES1AGnA/8kQ3k SMTpbeUYuSJLuHXvDAJJ3D12HbEZ/COl/Sviqk2/MnJCnPrayiuNKBCHbho8+mcUimEm dLw8UjJc9GMzVAAUv15nariA0fP/xCMPDWhKf4sEv243fqesi7T+/u38Sim6eBdr6g68 qKrxkqdGQFS4ajr3qMXWcQAniabZ0cwnZAPAbYahYu58Hnp/9GxLLLXpoU1UH77EW4gh 1E+HSnO5rNTUUDQF2tWF5pw/emb99DKqDfLdME+g31tEjNDjEzbsff6ZF6q8EkUDuuks z8BQ==
- In-reply-to: <20180317231715.dc5zcswwoe5vf2zx@gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20180316203930.f6mikhp7iiltgmpb@gmail.com> <7323.1521286049@thecus> <20180317231715.dc5zcswwoe5vf2zx@gmail.com>
To what Oliver said, I would just add: I'm much happier accepting
patches that stay somewhat close to the code formatting style that's
already in use, which is pretty lax in general but boils down to:
- don't use // comment to end of line
- don't use CamelCaps except for typedef names
- indent 4 spaces with 8-space tab stops if you use tabs at all
- stick to 80 columns where possible (yes, we're old fogeys)
- use whitespace after keywords and commas and around open/close
braces, but not after open or before close parens and brackets
- violate that latter for readability, especially with extra line breaks
Messages sorted by:
Reverse Date,
Date,
Thread,
Author