Re: Why sourcing a file is not faster than doing a loop with eval, zle -N

[Sebastian Gniazdowski <psprint@xxxxxxxxxxx>]

On 19 marca 2018 at 10:07:38, Joey Pabalinas (joeypabalinas@xxxxxxxxx) wrote:
> After spending a bit of time writing up a patch and testing it, getline()
> unfortunately didn't seem to solve the original performance problem

By "original problem" you mean: sig-mask being updated too often (through a syscall, like strace reported) ? AFAIR Bart patch (committed) vs. Peter patch (fgets, not commited) was resolved to: fgets is faster, but it has problems, and Bart's patch is too very fast, and correctly solves many-syscalls problem. So if you wrote the same what Peter did, but instead of fgets you used getline, then it should solve too the many-syscalls problem and be even faster than HEAD. So maybe by "original issue" you mean something else, probably: "getline should be significantly faster than current HEAD (Bart's patch commited)" ? So in general all this would mean that getline doesn't provide performance gains comparing to current HEAD?

-- 
Sebastian Gniazdowski
psprint /at/ zdharma.org