Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] _add-zsh-hook: add -L
- X-seq: zsh-workers 42739
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: Daniel Hahler <genml+zsh-workers@xxxxxxxxxx>
- Subject: Re: [PATCH] _add-zsh-hook: add -L
- Date: Tue, 01 May 2018 09:48:41 +0200
- Authentication-results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1525160931; bh=Od9MBOmi8Zs6j4+2p8Bz8e0Nm+m91CW+BudfBt8UdXw=; h=From:References:To:Subject:Date:From:Subject; b=mCAaWGET3FOXuRde9K9ES5lA4/seuokdLVR6TSEHhoT02XAS0/sFKKIeBMJEJedPYKM07hov4aUAtT4/0jT+lZoRr7tWUUr0417MUW4Je/7RyAa6wgmB4m0P8TNalSHkDo9U3DDEfAhKYxL8/+bEoUc83EuZkcqFUY8+pLENVkrJut4zcHtGqLLtE8AkDUgWFjXP2Taff7chkw07ZDts3Jda7QilB8xjtoFSkCHLzBxw2i3FzHIgpC8FYvdd1AznA8DzjIhDUrcbJ9rjlYaU92XNukXOC2BlvYuEzSQmR2TXABmvuEDe33Bblu+wzX979Cr06wIClZUFdLVe/+fEdw==
- In-reply-to: <20180430123153.29371-1-genml+zsh-workers@thequod.de>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20180430123153.29371-1-genml+zsh-workers@thequod.de>
Daniel Hahler wrote:
>
> --- a/Completion/Zsh/Function/_add-zsh-hook
> @@ -14,8 +14,9 @@ _add-zsh-hook() {
> - '(-D)-d[remove HOOK from the array]' \
> - '(-d)-D[interpret HOOK as pattern to remove from the array]' \
> + '(-D,-L)-d[remove HOOK from the array]' \
> + '(-d,-L)-D[interpret HOOK as pattern to remove from the array]' \
> + '(-d,-D)-L[list current values of the array with typeset]' \
You need spaces rather commas inside the exclusion list.
I'd also convert HOOK to lowercase while you're there. Those
descriptions look like they have been copied and pasted from
documentation where full usage has been presented first - something
like:
add-zsh-hook [ -L | -dD ] [ -Uzk ] HOOK FUNCTION
In completion, we're not presenting the information that the first
normal argument is 'HOOK'.
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author