Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
[PATCH 2/2] Fix two C nits
- X-seq: zsh-workers 43028
- From: Eitan Adler <lists@xxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: [PATCH 2/2] Fix two C nits
- Date: Sat, 16 Jun 2018 01:04:27 +0000
- Cc: Eitan Adler <lists@xxxxxxxxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=from:to:cc:subject:date:message-id; bh=RtPcjRgh0xR8EHFqkAjXpuG0d9wgDzbJ70pLlWKKc7s=; b=Yfa+Hrgc+y/S6IFyzIteD/PtsVbQA24MAQ+K4YmVpM1F3vfwKTR9W/2gGOFEhRbWSG lAovoEJnHQSC5gfiCQJmzROioV9WPOjvydm7TfTKeodHaTuhY9ZFmYOa6Z2vgtTFIKSp mqjxY4ZYwJ8fGFG/+B/e/YAkwf+Z4Rv1/ut5k=
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- avoid returning from a function that will never return
- use "ifdef" instead of "if" for checking if preprocessor exists
Signed-off-by: Eitan Adler <lists@xxxxxxxxxxxxxx>
---
Src/exec.c | 1 -
Src/zsh_system.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/Src/exec.c b/Src/exec.c
index d44527841..b36bcef64 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -4954,7 +4954,6 @@ getpipe(char *cmd, int nullexec)
execode(prog, 0, 1, out ? "outsubst" : "insubst");
cmdpop();
_exit(lastval);
- return 0;
}
/* open pipes with fds >= 10 */
diff --git a/Src/zsh_system.h b/Src/zsh_system.h
index 5339b496f..d9b8617c5 100644
--- a/Src/zsh_system.h
+++ b/Src/zsh_system.h
@@ -735,7 +735,7 @@ extern char **environ;
/* These variables are sometimes defined in, *
* and needed by, the termcap library. */
-#if MUST_DEFINE_OSPEED
+#ifdef MUST_DEFINE_OSPEED
extern char PC, *BC, *UP;
extern short ospeed;
#endif
--
2.17.1
Messages sorted by:
Reverse Date,
Date,
Thread,
Author