Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: A repeating core, just sharing backtrace
- X-seq: zsh-workers 43157
- From: Peter Stephenson <p.stephenson@xxxxxxxxxxx>
- To: Zsh hackers list <zsh-workers@xxxxxxx>
- Subject: Re: A repeating core, just sharing backtrace
- Date: Tue, 10 Jul 2018 14:38:32 +0100
- Cms-type: 201P
- Dkim-filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180710133835euoutp027b0d8d9d5b165ebb2f68f64b3c35e095~ABX7oi6N00940909409euoutp02P
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1531229915; bh=fRoxuRQDa8RF5gUf0Qd3Z7HVbgxPkgTu0hHQxTfUiio=; h=Date:From:To:Subject:In-Reply-To:References:From; b=AmI2r+b1vyrcTA4EkI0oMXRCFR4yuulAB4sdj1M/i5SwCIGTXUqbfHoIpE03QPbOF HxKxhJzuu9TMgwItn2NPa+nLCswBvM1UfBrCVzNLMtFlKPRArUWYjdYEd9eeBpZ9Zk gq9BT7Y2bakgyjgNsdVMUgVCPmCuFdnQxbo/ozuo=
- In-reply-to: <20180710143319.340e1bdf@camnpupstephen.cam.scsc.local>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- Organization: SCSC
- References: <CAKc7PVDcW6SRsk7XtjvNkj49C2-o-_BmQywYizh=QOvu5z16iw@mail.gmail.com> <CGME20180705134128epcas4p426987f777de70dfe2dfacda469b39424@epcas4p4.samsung.com> <CAKc7PVBQn-ZjZ1T0TLqofETRiRw3xTExJ3aN10FWPqEQSi180w@mail.gmail.com> <20180710143319.340e1bdf@camnpupstephen.cam.scsc.local>
On Tue, 10 Jul 2018 14:33:19 +0100
Peter Stephenson <p.stephenson@xxxxxxxxxxx> wrote:
> diff --git a/Src/exec.c b/Src/exec.c
> index 5864020..47a4567 100644
> --- a/Src/exec.c
> +++ b/Src/exec.c
> @@ -4418,7 +4418,9 @@ gethere(char **strp, int typ)
> while ((c = hgetc()) == '\t' && strip)
> ;
> for (;;) {
> - if (bptr == buf + bsiz) {
> + if (bptr >= buf + bsiz - 1) {
... make that "-2", because we need to allow for two *more* updates.
The previous logic just allowed for where we'd already got to, because
it just needed to check one position. That doesn't work any more.
pws
Messages sorted by:
Reverse Date,
Date,
Thread,
Author