Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] _pgrep: simplify the processing of '->state' actions
- X-seq: zsh-workers 43193
- From: dana <dana@xxxxxxx>
- To: Jun T <takimoto-j@xxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] _pgrep: simplify the processing of '->state' actions
- Date: Thu, 19 Jul 2018 14:44:42 -0500
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/60SZyqmKlMQkU+XujtpdBtyXHM5VvJ/gqlbzytrIa0=; b=SzJxk5yFGHvPY7QGMrY5S8ti3mU2sI+CFmn+B74qi5dmLNXWRz67xmgv8e62fBrkD0 d1QBzNWLwD/ZAL9HQ190/2xUZkqyQ9Mr/GSCHMow+Fph1iYh4ZLvxEPsDvufho4jl228 E6A8jldA5ccSMSgR2aEPLNXDIkrrKnyarcA0mapI09PAhNIDTUkxScoq/7LShhNU4ER9 apOiIX7qgudxANKH+MEmpHF0h6eq5DcVr3XhNRD0TBipDbbqNibduLQUhARkW2wDpLGp G5o//4kJI26Zb1bjS8FxhAmvilhhU/wd8au/+HbwTkZiCni0F7BAn42dN0H/94Ng0T17 KOIQ==
- In-reply-to: <064FE4EC-2987-49F5-8BA0-666E1D1568B2@kba.biglobe.ne.jp>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <064FE4EC-2987-49F5-8BA0-666E1D1568B2@kba.biglobe.ne.jp>
On 19 Jul 2018, at 05:06, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>-# - We assume that Linux systems use procps-ng — specifically, procps-ng >=3.3.4
>+# - We assume that Linux systems use procps-ng - specifically, procps-ng >=3.3.4
Would you guys prefer that i not use em dashes in source comments? I guess i'd
just assumed anything UTF-8 would be fine, but maybe that's a selfish
assumption. I can use '--' instead if it's a problem.
On 19 Jul 2018, at 05:06, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>- '-J+[match only on specified project IDs]: :->projid'
I'm not sure about moving this. I mean it'll work either way, but why make this
a special case? Why not also break out -z? And then if we're doing that for
Solaris, why not also break out -S for FreeBSD, -T for OpenBSD, and so on?
If we don't like the p[gk]opts filtering method, that's one thing (i had just
extended the way the function was already set up, but obv we could build arrays
in case clauses or whatever instead) — but as long as we're keeping it i'm not
sure why -J alone should be exempt.
dana
Messages sorted by:
Reverse Date,
Date,
Thread,
Author