Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] _pgrep: simplify the processing of '->state' actions



On 19 Jul 2018, at 05:06, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>-# - We assume that Linux systems use procps-ng — specifically, procps-ng >=3.3.4
>+# - We assume that Linux systems use procps-ng - specifically, procps-ng >=3.3.4

Would you guys prefer that i not use em dashes in source comments? I guess i'd
just assumed anything UTF-8 would be fine, but maybe that's a selfish
assumption. I can use '--' instead if it's a problem.

On 19 Jul 2018, at 05:06, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>-  '-J+[match only on specified project IDs]: :->projid'

I'm not sure about moving this. I mean it'll work either way, but why make this
a special case? Why not also break out -z? And then if we're doing that for
Solaris, why not also break out -S for FreeBSD, -T for OpenBSD, and so on?

If we don't like the p[gk]opts filtering method, that's one thing (i had just
extended the way the function was already set up, but obv we could build arrays
in case clauses or whatever instead) — but as long as we're keeping it i'm not
sure why -J alone should be exempt.

dana



Messages sorted by: Reverse Date, Date, Thread, Author