Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH 2/5] _hg: declare appropriate local parameters for ->string form
- X-seq: zsh-workers 43249
- From: Peter Stephenson <p.stephenson@xxxxxxxxxxx>
- To: Anton Shestakov <av6@xxxxxxxxxxxx>, <zsh-workers@xxxxxxx>
- Subject: Re: [PATCH 2/5] _hg: declare appropriate local parameters for ->string form
- Date: Mon, 6 Aug 2018 16:38:03 +0100
- Cms-type: 201P
- Dkim-filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180806153807euoutp012932dc1d9b8e4be78fdff8d8ce8ee184~IVbAOmbHE1915219152euoutp01R
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1533569887; bh=uwI/xbWrQ/j8aIOyFxwHuF8l+PUoQXiDkgAON/B6f80=; h=Date:From:To:Subject:In-Reply-To:References:From; b=hWBrRPXD9WWQqhYlsvq40KFXRBLtD0Yc5yuY0ts+mBqq6nA35eD92KB5FlGbIwwoa bHujxurz8jY+sx5P/6pRxSacRQqN6cRY0AXN0SNh0o8QqFxrLsLNCknQDPT0qZ7jiQ 6kvQQz82SThRvbh6LunlIGSW5TasQRPPa77wLKH4=
- In-reply-to: <20180806233155.1165c215@neuro>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- Organization: SCSC
- References: <20180806072813.5051-1-av6@dwimlabs.net> <20180806072813.5051-3-av6@dwimlabs.net> <CGME20180806092113epcas2p1be3488679902085a99d66331745e15d4@epcas2p1.samsung.com> <20180806092032.uizmxvlc2oku2ik6@tarpaulin.shahaf.local2> <20180806092931eucas1p1c89ebf9f2ee4f5bb40ac2c650cf4a6f2~IQZLFzTOa0396203962eucas1p1k@eucas1p1.samsung.com> <20180806190914.246b9514@neuro> <1533557076.2551857.1464840032.5374495A@webmail.messagingengine.com> <20180806233155.1165c215@neuro>
On Mon, 6 Aug 2018 23:31:55 +0800
Anton Shestakov <av6@xxxxxxxxxxxx> wrote:
> I've edited the 2/5 patch to manage local return value based on the
> feedback, and I'll wait until tomorrow in case there's more feedback,
> but for now the question is what people here generally prefer? I can
> resend the whole series, or only changed patches, or I can push to a
> code hosting site or something.
I think we've actually got enough already, though I only use Mercurial
for simple tasks so I don't really know enough to comment on the
user-visible functional aspects. But if nobody else does we
might just take your word for it and commit them.
pws
Messages sorted by:
Reverse Date,
Date,
Thread,
Author