Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: "off by one fix in multiple prompts" breaks multiline prompt
- X-seq: zsh-workers 43286
- From: dana <dana@xxxxxxx>
- To: Peter Stephenson <p.stephenson@xxxxxxxxxxx>
- Subject: Re: "off by one fix in multiple prompts" breaks multiline prompt
- Date: Mon, 13 Aug 2018 09:19:41 -0500
- Cc: Guillaume Chazarain <guichaz@xxxxxxxxx>, zsh-workers@xxxxxxx, warepire.ml@xxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=T/0z3J1nbaTGEkYY5nKMccqUb3ATZXwj5fcHyba6a8E=; b=qlWoBwyU6xs7o2gqgj8qIL8UQgxNh+g9Y1UKjhiH3NlkgqyvNorwG8wg2LVaZ7Fdma SMg3BdEWWYrl7fDu3ueiDbo2pFJ83eO7u0TyfMHHLj1LAzRWDZ9qiU6l1g1t4NOGGlxt awi2za3GXXtRpekky56iGqWTq9FEeAEnyLx5Tc8Rsu4RqSYijM2x/zNZaPS21eB2VpOV Ec+Cbr35VgjMSun6pvwJe5v1vnQ6nXslrqELlBW6oUnV0YE+4U4v5dgqBg2fmHuTGoFC L3qgGqR8t7tCAcM9S5ohtJ9/UFnRK4FTMQPb+IIVkBdh3q32yvZtGHGXbPxF2rOKejMu 6+ig==
- In-reply-to: <20180813125810eucas1p181a58cb55dc815863d6d81e1cd629d71~KcwV9B7ZD1627716277eucas1p1o@eucas1p1.samsung.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CGME20180810072702epcas5p4ecaa5cffa5dc7668e2b2aa3a30824f36@epcas5p4.samsung.com> <CAA879TMRSWDSkqHP206-JLaJ8F4U=18DYU1CpCwCQ4iWMu_4Tg@mail.gmail.com> <20180813084255eucas1p102bc21872ad72a2cd049d8d9db2f0e86~KZResIryo0309103091eucas1p10@eucas1p1.samsung.com> <CAA879TPfqJbR1vwYfbRTCWoqkC-iH7pXHSwGYUzqOj8CT95xPg@mail.gmail.com> <20180813113640eucas1p19d52c9c05089626f375a00c5115aef32~KbpML4Mzp0510505105eucas1p1P@eucas1p1.samsung.com> <CAA879TOk3wqsY96dipo=gvFeN0OXTC0ei9i0xRsSyYyVmFG2rg@mail.gmail.com> <20180813125810eucas1p181a58cb55dc815863d6d81e1cd629d71~KcwV9B7ZD1627716277eucas1p1o@eucas1p1.samsung.com>
On 13 Aug 2018, at 07:58, Peter Stephenson <p.stephenson@xxxxxxxxxxx> wrote:
>I suspect dana was saying we need something like this? Has this got
>anything to do with it? (Second guessing other people's fixes is really
>hard work...)
Yeah, i probably should have tested the patch that was actually submitted,
sorry. We were kind of working on it in parallel after Wapire suggested on IRC
that that might be a fix to their problem.
The additional change you mentioned addresses the difference between the patch
as submitted and what i was testing. However, i just tried it and it does not
fix this issue (where the last 'hard' line of the prompt wraps).
Looking at that function again, i wonder if the original problem was actually
related to the fact that it compares the current column count (and
potentially increments the height) before checking whether the current character
is a new-line? That would explain why it was producing an extra cup when it
encountered a line that was exactly as wide as the screen.
dana
Messages sorted by:
Reverse Date,
Date,
Thread,
Author