Re: [PATCH 2/2] vcs_info git: For the branch name, try to find a symbolic name before falling back to a raw commit hex.

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Frank Terbeck wrote on Mon, 20 Aug 2018 13:45 +0200:
> Daniel Shahaf wrote:
> > 1. Adding knobs induces a maintenance cost going forward.  Is that cost
> >    justified in this case?  We can always add the knob later if there's
> >    demand for it, but it's harder to take away behaviour once it has
> >    been released.
> >
> > 2. At what point in the if-chain do we raise the white flag^W^W^W^W
> >    check the "early exit?" style?
> >
> > I suppose we could overload the `use-simple` style for this purpose (the
> > git backend doesn't currently use that style).  The `get-revision` style
> > is also relevant.
> 
> Yeah. The git backend is pretty complex as it is. Maybe it's not worth
> it, to make this configurable. I don't know.

Let's leave the style out until/unless someone asks for it.  It'd be trivial to add
later if we want it.