Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: Rimmerworld pipeline race
- X-seq: zsh-workers 43414
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
- Subject: Re: PATCH: Rimmerworld pipeline race
- Date: Fri, 7 Sep 2018 16:40:11 -0700
- Cc: Peter Stephenson <p.stephenson@xxxxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yghBTsE4z3fm2Hn0jxm2ZIuukBh/lxSwtUXG7o9GVPg=; b=ZnQKLdowAqSvSw+K4nsfQOWhvsNu6DWhqBJ0dPDPufl0vav2qAlPUZalXMJvrFbu13 YatemiJh2+w/tfP6uKMqfjuyHfd24x47iOAajBdKvPIuFxR/UqfrVFf5Y4ds1eLyjQnL e7DRVCO16+7xaCx+XY9vWdrRZ+8UWb9BuFYqxrsEmjsBTV/DbybN/nD5ArN28vB1wMJ6 iagf/+0XyoPAuSzQXvl7Gk7+M7wHcnsVLlVvoJJM+gsF8Rdi4CUlc9SX+AHsSRbmKe2B FIb43Ly1rRpw/NRzldA4/n2wZDIt+VchHnd/GaiOvf7DpE9+8Pvvxm4HEt5QCut2/5XR i28w==
- In-reply-to: <577129092.1106031.1536338813897@mail2.virginmedia.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CGME20180905200816epcas5p18ce6c49baa637e7d83a769e97c4364fb@epcas5p1.samsung.com> <20180905210740.5a6aec15@pws-HP.localdomain> <20180906090902.1f344e9f@camnpupstephen.cam.scsc.local> <20180906092250eucas1p13d651e07ae627d179dd0701e65f912d6~RxTLztJrP2263722637eucas1p12@eucas1p1.samsung.com> <CAH+w=7ZH1d8RZaHNVhb2k+RqBb_8kgxDurewtk1a6TWG9Vvh5Q@mail.gmail.com> <20180907101852.62415ff9@camnpupstephen.cam.scsc.local> <20180907122145.2af5bcba@camnpupstephen.cam.scsc.local> <20180907150140.46a05880@camnpupstephen.cam.scsc.local> <20180907145828eucas1p2755db3a0eb9725cb3a29121033e77f21~SJhg-Al9h2728227282eucas1p2z@eucas1p2.samsung.com> <577129092.1106031.1536338813897@mail2.virginmedia.com>
On Fri, Sep 7, 2018 at 9:46 AM, Peter Stephenson
<p.w.stephenson@xxxxxxxxxxxx> wrote:
>>
>> Here's a more sophisticated fix, though I'll take votes on which to use
>> for now.
>
> (Don't all shout at once.)
Timezone difference and mornings are $REALJOB busy for me, so I
couldn't answer right away.
> Actually, I can't see a good reason why I shouldn't simply commit this. It's much
> the neatest way of keeping the states aligned. I'll do that.
I was going to ask whether this replaces or adds to the previous
patch, but either way, yes, do this.
Is there a point to replacing &dummy with &gleader in the call to
read_loop(), other than to save declaring "int dummy"? It doesn't
appear that read_loop() puts returns anything useful via &gleader.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author