Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 2/2] Fix Completion iptables 194: ;& => ;;

a-wing wrote on Mon, 08 Oct 2018 11:24 +0800:
> ---
>  Completion/Linux/Command/_iptables | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Completion/Linux/Command/_iptables b/Completion/Linux/
> Command/_iptables
> index ae8d66ea4..2d9697418 100644
> --- a/Completion/Linux/Command/_iptables
> +++ b/Completion/Linux/Command/_iptables
> @@ -191,7 +191,7 @@ case "$state" in
>      _wanted targets expl 'builtin target' compadd \
>          ACCEPT DROP QUEUE RETURN DNAT DSCP ECN LOG MARK MASQUERADE MIRROR \
>  	REDIRECT REJECT SNAT TCPMSS TOS ULOG && ret=0
> -  ;&
> +  ;;

I'm sorry but this patch is wrong.  iptables(8) explicitly states:

[[[
TARGETS
                                                    … the value of the target,
       which can be the name of a user-defined chain, one of the targets
       described in iptables-extensions(8), or one of the special values
       ACCEPT, DROP or RETURN.
]]]

For future reference, log messages should describe the functional change and
its purpose, not the syntactic change.  That is, it should say something
_beyond_ what can be understood by parsing the unidiff.

Thanks for the patch,

Daniel
Messages sorted by: Reverse Date, Date, Thread, Author