Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] [long] typeset doesn't report tied parameters (and related issues)



On 7 Oct, Stephane Chazelas wrote:
> +#define PM_NAMEDDIR     (1<<31) /* has a corresponding nameddirtab entry    */

On a 32-bit system, this now results in integer overflow compiler
warnings. flags in struct hashnode is declared as being of type int.

unsigned int might have been a better choice for a variable holding bit
flags in the first place but struct hashnode is widely used so changing
the type probably is not a matter of just changing the one line. With
that in mind, should we change it straight to uint64_t and open up space
for expansion?

We don't have any existing uses of stdint.h types like uint64_t. I
wouldn't blink at using them in other codebases but do we need to add
any autoconf magic to preserve wide portability?

Oliver



Messages sorted by: Reverse Date, Date, Thread, Author