Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] [long] typeset doesn't report tied parameters (and related issues)
- X-seq: zsh-workers 43673
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: Zsh hackers list <zsh-workers@xxxxxxx>
- Subject: Re: [PATCH] [long] typeset doesn't report tied parameters (and related issues)
- Date: Thu, 11 Oct 2018 11:45:22 +0200
- Authentication-results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1539251124; bh=LFNZBbPXY6rKMk/BS8u2csNUbamyievx9CkrUOw8VUk=; h=From:References:To:Subject:Date:From:Subject; b=PX+IMd5C5xyWC7/XxNU9RNddEXuOcFuaC8e+rnfFwm5k9snqQo6R3D53kn1mnjsAg8FcOWsuFMQNRNk3omOspkxiL+KfE8unuw0NBu23sZl05Skda2SwbhoduIqXvG0KxenBSvo/zw+P6UK/MiB6ryUPeNx/7H2INx1JbSpszLTdu7xirR4AhEeSfFzGNDX8Vd+pr7+3No5UK37Li9QNN/Ni36AyBvwtmSSQAbRWXg4+sF4orPjT3s+ngiDMeB4oyqaU1jv/w0+v5owbGwJPBo7c/9ePERAFaduE9n4yiUONdwJD7YPHTcYRjS9g1E8fbww8PysttP5SBsfE6NqvXQ==
- In-reply-to: <20181007133545.zzkrbc3ed6shnk3e@chaz.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20180924210550.carijwjibarjivu4@chaz.gmail.com> <20181007133545.zzkrbc3ed6shnk3e@chaz.gmail.com>
On 7 Oct, Stephane Chazelas wrote:
> +#define PM_NAMEDDIR (1<<31) /* has a corresponding nameddirtab entry */
On a 32-bit system, this now results in integer overflow compiler
warnings. flags in struct hashnode is declared as being of type int.
unsigned int might have been a better choice for a variable holding bit
flags in the first place but struct hashnode is widely used so changing
the type probably is not a matter of just changing the one line. With
that in mind, should we change it straight to uint64_t and open up space
for expansion?
We don't have any existing uses of stdint.h types like uint64_t. I
wouldn't blink at using them in other codebases but do we need to add
any autoconf magic to preserve wide portability?
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author