Re: [PATCH] ztrsub() execution time / 2

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Sebastian Gniazdowski wrote on Wed, 17 Oct 2018 21:02 +0200:
> On Wed, 17 Oct 2018 at 16:25, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > As far as I can tell, this patch is the sort of transformation that an
> > optimizing compiler should do by itself.  In fact, I'm having a hard time
> > seeing how the sequence of "BRANCH IF EQUAL" / "BRANCH IF NOT EQUAL" /
> > "INCREMENT" assembly instructions would be altered by the patch.
> >
> > If your profiling was performed on zsh compiled with -O3, I would suggest that
> > you file a bug against your compiler's optimizer.
> 
> Why not "do it right, then do it yourself"? Why ignore -O0 zsh users?
> Should I subscribe to compilers mailing lists and investigate this
> well defined 1-line change, i.e. possible to grasp by logic?

I have a hard time charitably interpreting what you just wrote.  It
doesn't come across as constructive.

I think the patch should not be applied because it makes the code harder
to read and to maintain.

Daniel