Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: fix completion for ack 3beta

On Thu, Nov 01, 2018 at 01:41:07PM +0100, Oliver Kiddle wrote:
> The ack completion fails with ack 2.999 because the output from the
> --help-types option has very subtly changed (first becomes First).
> 
> Also the ${+commands[${words[1]}]} test is not helpful because that
> will always return 0 for full paths - I was trying it with "./ack"
> having downloaded the standalone Perl script.
> 
> And while I was looking at it, I've updated the options.

Scanned over the diff and the changes look good to me.

Trying it out myself also works great, so ACK.

-- 
Cheers,
Joey Pabalinas

Attachment: signature.asc
Description: PGP signature

Messages sorted by: Reverse Date, Date, Thread, Author