Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] select-bracketed: set nocprecedences to force native precedence ordering
- X-seq: zsh-workers 43782
- From: Joey Pabalinas <joeypabalinas@xxxxxxxxx>
- To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] select-bracketed: set nocprecedences to force native precedence ordering
- Date: Tue, 6 Nov 2018 13:47:16 -1000
- Cc: Joey Pabalinas <joeypabalinas@xxxxxxxxx>, "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CIbVZVXrmRhyl23B+6LUffwbQ3tL8mnCom8oqZiYjU0=; b=cspWCBnqRe1oTNOgJlWoDwmCC40oa7SA4djxmTznRqQT20CmrYA4DndpnrCFCcmWN6 KyhIgL9ll1dYfytgry4zlOE6JbNrDUYUy/ObJ4B8VLj6eNnjw5NLD47nNPvl4BdUfq1g jk2U4EAKOUT+x4oBKW9C0ID0DybZvvJEXaughp7LLFSlGv3ffmiMX+9+jfMevIPHuYfa esYPKcEB4R/a20guULNUzkEIg9U4nVA8FMt+VnAv9vT6asZmFky5khCENySCnZ2pXM6B vrafmw2lzMSYoPCz9y08hA/u9LoKSaGP+WhRbjcedkLvPDFuKMevl4Qy22yuy4kMo+jl xlQA==
- In-reply-to: <CAH+w=7YNUjeZMVne6WfF9=MRGMcsroGemCNdTy5Awm0TLpjSRw@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mail-followup-to: Joey Pabalinas <joeypabalinas@xxxxxxxxx>, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>, "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <389ebb53e6d5b8cfe9985af3d41574679e5ce4b8.1541547033.git.joeypabalinas@gmail.com> <CAH+w=7YNUjeZMVne6WfF9=MRGMcsroGemCNdTy5Awm0TLpjSRw@mail.gmail.com>
On Tue, Nov 06, 2018 at 03:40:59PM -0800, Bart Schaefer wrote:
> Not that I object to unsetting cprecedences, but is it necessary to do
> so if you've rearranged the parens?
It isn't, but in my opinion expressions like this always have a tendency
to confuse. I find it helpful to add the parentheses even when not needed
if for no other reason than to make mentally parsing the code easier.
If you think it's a bit superfluous then I don't mind removing that part and
sending a quick v2.
--
Cheers,
Joey Pabalinas
Attachment:
signature.asc
Description: PGP signature
Messages sorted by:
Reverse Date,
Date,
Thread,
Author