Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Completion: _opkg: Support gain-privileges
- X-seq: zsh-workers 43992
- From: dana <dana@xxxxxxx>
- To: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] Completion: _opkg: Support gain-privileges
- Date: Sat, 12 Jan 2019 13:08:30 -0600
- Cc: Zsh workers <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=o0CVJsavnvjXYwO89mK2BdrsVuGd45VO6WeFOCgnbes=; b=wM7tYH965mzeYPDJxi1eNjOAOs5qqiGsxkS9CXBmuW0wVuRrLMQyIBVBtScWSPSu8/ jO86Z9A+9DNjk8Yj6SY2uowQEma0D9Q2Kvr9iX1j30z2+vPJTNbjgZ5MkvsKJjM/TSIX lr+8FlaegNtHf4INq+x/avVplhDXsyjoq2DtJcEcWa80zqao2iJSPi1/VaK9x7Q0IouV RY+hW/zwt9lZ6riNsnD2oA0EqeuskSDnZUA9+ecNrl5IpaQ3ghxZpgBFstEYwGSVlCQ2 0ZuaQpAhJP6md0MIE2t4Ys18O5UXEBCW3eYvMtQBYRa3ec6hSiz/KJV1B+YLi5dW+QnL ZCMQ==
- In-reply-to: <20190112171028.36htyrmgrxat4jle@tarpaulin.shahaf.local2>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <E1AAD4A3-482A-4173-8579-05F0B38951B1@dana.is> <20190112171028.36htyrmgrxat4jle@tarpaulin.shahaf.local2>
On 12 Jan 2019, at 11:10, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
>I don't think so. Even an "empty" result could be expensive to compute:
>for example, it might require a network round-trip. I think _opkg
>shouldn't call _store_cache when _call_program returns non-zero.
Well, i think that's effectively the same thing in this case and certain
others i'm imagining. (Or at least i assume so; there's not really any
documentation for opkg that i'm aware of, so who knows what actually causes it
to return non-zero.) Just felt like it might save some boiler-plate, which the
caching logic is extremely heavy in already, to have a standard option handle
it. I can just add the guard to each _store_cache call myself, though, obv
dana
Messages sorted by:
Reverse Date,
Date,
Thread,
Author