Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Ignoreeof warning message regression
- X-seq: zsh-workers 44062
- From: David Bohman <debohman@xxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Ignoreeof warning message regression
- Date: Tue, 12 Feb 2019 09:47:03 -0800
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=ewwGDcKq/vYFz0nJHU072nGO5y6kA+cc6mVB/X3o2Ks=; b=AksfBawK9Xgojm1iUKV8kBREfwvTEj+QfNLdS6EUwgt6eN+DEiglL3SgcaaalXnsvq fBIsPobrMZ9+C6Lw5I07WkXeSqq9PU8oodHQ3EZ50tR0POmzl5JpneNqsMTx7wwI2URU j8v3IX22Au1Zcwv7WaDVGaJipy/P+IMXGfwdeAEynsRNH/0yUGqJLcPihaVHwoOHtGZ5 3JNXq14gQNQrdDIBwHF3t0hkq2HZitlN+7GGanXaeZcaqMB0DWbIwpY2eGz6KDXtKLQm ltIpSPbe1oAWT4qPum46zSjZA2AnETHzwFoHlhU7K/YpIN+oIJq4hDTcKiZcfJxcC5cD HVIg==
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
This is an old regression, which apparently occurred between release 5.3.1
and 5.4 of zsh.
If you have the ignoreeof option set, and type a CTL-D to the shell, you
are supposed to get a warning message:
zsh: use 'exit' to exit.
Instead, a blank line is emitted. This was introduced by
commit 34656ec2f00d6669cef56afdbffdd90639d7b465, specifically the change to
Src/Zle/zle_main.c.
The problem occurs both on Ubuntu 18.04.1 running zsh 5.4.2 and macOS
10.12.6 running 5.4 forwards to 5.7.1. Stock macOS 10.12.6 contains zsh 5.2
and does not manifest the bug.
The problem disappears when the change to Src/Zle/zle_main.c is backed out.
index 3487b5d9f..71930f76b 100644
--- a/Src/Zle/zle_main.c
+++ b/Src/Zle/zle_main.c
@@ -1256,7 +1256,6 @@ zleread(char **lp, char **rp, int flags, int context,
char *init, char *finish)
resetneeded = 0;
fetchttyinfo = 0;
trashedzle = 0;
- clearflag = 0;
raw_lp = lp;
lpromptbuf = promptexpand(lp ? *lp : NULL, 1, NULL, NULL, &pmpt_attr);
raw_rp = rp;
I am aware that backing this out may break other things, but perhaps it
might give a hint to someone who is familiar with this area of the code.
Thanks.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author