Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
missing braces or wrong indent?
- X-seq: zsh-workers 44285
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: missing braces or wrong indent?
- Date: Sat, 11 May 2019 20:04:44 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=h2KdrHObguCsEE+lxkRQi2K7Sr+vQoCYAjwLRVY2faw=; b=WenLUPOak+ERMnxAUoQi8oz0Dfp22AQOUk88bwcDHswXeM4/gK3Dxh2di+sTp+h96q pXFIa1PTxyWgD/28KoIyvKXnhS+u2O4GwFYMJ9l7+M5l2TvujykYzCVRmk3AuCJzNscN Odnx+XmbMljxjKDqCjLoCe3CjQYXaF5DWxtIEA3xO7kpgsMAlF5UEA5l1AxKBKEOL7rt qhU1eJD7OBnyWHOSm6MD0+aZxYn0USSGIEJBqgUe1JEe1NOiZvB5M+W+c9fVS/W4DwCO vjvzNxFE8SpSyr1+GTGAyZ0Eo2xb6eNUs5AeGZtjNaRsHlqFHGiKi7jG82DFLhml27Cm 8rcw==
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
Just submitted a new coverity build and looked at some stuff it was
unhappy about; this isn't one of them but what is going on here?
clone.c::bin_clone
55
if (!pid) {
clearjobtab(0);
ppid = getppid();
mypid = getpid();
#ifdef HAVE_SETSID
if (setsid() != mypid)
zwarnnam(nam, "failed to create new session: %e", errno);
#elif defined(TIOCNOTTY)
if (ioctl(SHTTY, TIOCNOTTY, 0))
zwarnnam(*args, "%e", errno);
setpgrp(0L, mypid);
#endif
dup2(ttyfd,0);
This/these if statements look completely bogusly indented, but maybe
it's also missing braces? I can't tell because I have no idea what it
wants to accomplish.
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author