Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails
- X-seq: zsh-workers 44463
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- Subject: Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails
- Date: Fri, 28 Jun 2019 02:20:02 +0200
- Cc: Kamil Dudka <kdudka@xxxxxxxxxx>, zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=39WNjIS2JRQHkP2IBwk+bJRdQMEZZeB+qXbx7ll+5KY=; b=pL5dvdRKFGnqOdUSTVIUsPOU+al4o8wexlXu9HsU85E23PH9ajyhfef2yj1B0elG62 uHD9hTXqoQ7h6f0s0UcGVrrn7yIdKCacuhV5NBdEN2Nfe6onaNOBuZIjMEQNth1lGTnW 6v5WxxkoBYYRPXFBy3x7FsL6Qo4JlTsfXvmcGWfJ9X/1Yhih/2X25LwVGMcAcsi0YbZD J3JFBKKEnPqdiaKsuimPWg6wO9kI8yIwetCRIIk1aAvuumPoJBdpXA/irqehiTyWmHWx WlpIE5/vmVZObuOTtaUa6sVGN02MIG4j05rIs4Bad1j/ceJB6p60QatcxVnFvO+Xrkfg 9HAA==
- In-reply-to: <797-1561676485.902916@C-Cf.WCnE.5Cn6>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20190626101908.548-1-kdudka@redhat.com> <797-1561676485.902916@C-Cf.WCnE.5Cn6>
I can reproduce *a* crash, not necessarily *the* crash, by making a
2x2 window and then maximizing/unmaximizing the window. It seems to
not reproduce if I have run any commands in the shell.
On 6/28/19, Oliver Kiddle <okiddle@xxxxxxxxxxx> wrote:
> Kamil Dudka wrote:
>> There is a bug report in Red Hat Bugzilla about zsh crashing on NULL
>> pointer dereference: https://bugzilla.redhat.com/1722703
>>
>> I was not able to reproduce the crash myself but the attached patch
>> should prevent zsh from crashing in this situation.
>
> It'd perhaps be good to add a DPUTS call here because while it is good
> not to crash the condition does perhaps indicate a bug and it'd be
> better not to hide it completely. I can't reproduce the crash either but
> there must be some plugins or url quoting magic going on here.
> More details of the setup used by the user might help find the
> underlying problem.
>
> Oliver
>
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author