Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails

X-seq: zsh-workers 44464
From: Kamil Dudka <kdudka@xxxxxxxxxx>
To: Oliver Kiddle <okiddle@xxxxxxxxxxx>
Subject: Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails
Date: Fri, 28 Jun 2019 10:12:04 +0200
Cc: zsh-workers@xxxxxxx
In-reply-to: <797-1561676485.902916@C-Cf.WCnE.5Cn6>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <20190626101908.548-1-kdudka@redhat.com> <797-1561676485.902916@C-Cf.WCnE.5Cn6>

On Friday, June 28, 2019 1:01:25 AM CEST Oliver Kiddle wrote:
> Kamil Dudka wrote:
> > There is a bug report in Red Hat Bugzilla about zsh crashing on NULL
> > pointer dereference: https://bugzilla.redhat.com/1722703
> > 
> > I was not able to reproduce the crash myself but the attached patch
> > should prevent zsh from crashing in this situation.
> 
> It'd perhaps be good to add a DPUTS call here because while it is good
> not to crash the condition does perhaps indicate a bug and it'd be
> better not to hide it completely. I can't reproduce the crash either but
> there must be some plugins or url quoting magic going on here.
> More details of the setup used by the user might help find the
> underlying problem.
> 
> Oliver

Thank you for analyzing it!  I do not have any more information than
what is available in the mentioned bugzilla.  So I asked the reporter
about their setup.

Kamil

References:
- [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails
  - From: Kamil Dudka
- Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails
  - From: Oliver Kiddle

Messages sorted by: Reverse Date, Date, Thread, Author