Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Valgrind tests (was: Re: Zsh: [7] + 23074 suspended (tty output))

On Sun, 14 Jul 2019 at 08:39, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
>
> Sebastian Gniazdowski wrote on Sat, Jul 13, 2019 at 16:31:10 +0200:
> > Daniel seems to be currently away or uninterested – could someone else
> > take a look at this?
>
> You're not entitled to having me review your patch, nor did I at any
> point commit myself to doing so.  Do not insinuate otherwise.

I wasn't leveraging any "entitlement" but just sincerely following
your shown interest to the Valgrind tests. Sorry if it turned out to
sound differently.

> As to your actual patch, no, I do not presently have time to review it.

Ok. I've waited 9 days and I'm afraid that the patch will get lost
somewhere. I just want to say, that the thing isn't actually a patch.
It's a tool that makes the current tests go through Valgrind. The
patch that adds the 'VALGRIND=1' variable to the tests' Makefile is a
+-2 lines patch. Therefore could someone else take a look? There's not
much to review.

-- 
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org
Messages sorted by: Reverse Date, Date, Thread, Author