Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: A serious bug in execution – where to debug?
- X-seq: zsh-workers 44613
- From: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>
- To: Sebastian Gniazdowski <sgniazdowski@xxxxxxxxx>
- Subject: Re: A serious bug in execution – where to debug?
- Date: Wed, 31 Jul 2019 00:11:53 +0200
- Cc: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CFXd4bwtjReEur4MrXNTHUDMNCdu2Ps7dBiaWQVcHOU=; b=aD8oSZZ4i8OajU42rp0xrA9mPyqmK5HsRUHfpYJIAESSBerlqEuHiyeh8ejRTDPG6p wmYDFl4BsLaYCVHlSYNq3qMbTDlNVsSiDPGfhLhXBsT/VeukIAS+anR1rh7kIlRcX5Rh x/XnIM3tqLnO4HmpwTjHfSlGCXhGkd8F+ZmkieRiiK9A0gWoN0KasrITDLlT4OnZDTwo S26g9YFE5LuTCyeR6zlj7q2X75CmrVXjkfeDkMBoZB2KyGs/4wfDQXRGDK62qTtVTIJu AcVU1wqWAZg0/8+ltwEgjCJM0lCUx2vYuBICJaV140+Jdbo4E/Z783ZN4tlHS181+Rx1 tw9g==
- In-reply-to: <CAKc7PVC__sg3j6ujohd1qU_chmRFECsE=VFamC3egBs4qhM2_w@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CAKc7PVCKrg_PnZ6jKLoAwR8XQnswT-Bs2TJA7oefhd_gRtHKUQ@mail.gmail.com> <CAH+w=7ZEukuvaOiBymgJ1nR1TbriEMSxx9L8-=hojxQoKOaRUw@mail.gmail.com> <CAKc7PVCbP5inrfFW3xiphBN5uH3o3ayVRnzzEbybfkp-Y5Fubw@mail.gmail.com> <CAN=4vMqkjK5hPxhhXYwp=4Sj49VfyZgEH06tK0vggnHyddbrsA@mail.gmail.com> <CAKc7PVC6vxkHRvRSQzPGxgOXLOMc-LyJaqA5DmsLXQ5tU8y3Hw@mail.gmail.com> <CAN=4vMo2-w8qEdsgWwZ5C3WE+ZRmBa-c2BxjpZ7NWpvNq_J2tQ@mail.gmail.com> <CAKc7PVC__sg3j6ujohd1qU_chmRFECsE=VFamC3egBs4qhM2_w@mail.gmail.com>
On Tue, Jul 30, 2019 at 11:54 PM Sebastian Gniazdowski
<sgniazdowski@xxxxxxxxx> wrote:
>
> On Tue, 30 Jul 2019 at 23:45, Roman Perepelitsa
> <roman.perepelitsa@xxxxxxxxx> wrote:
> >
> > On Tue, Jul 30, 2019 at 11:38 PM Sebastian Gniazdowski
> > <sgniazdowski@xxxxxxxxx> wrote:
> I avoided localoptions for performance – it consumes some time, as it
> (probably, but the performance effect is confirmed) allocates a new
> table of options and fills it with defaults. So I've decided to write
> an option-transparent code. But turns out that this might be hard in
> case of such options as errreturn. I'll think about whether to replace
> inline conditions with if-then or to do emulate -L.
Keep in mind that 5.4 (I think it was 5.4) had a bug where a false
condition under `if` was causing the function to return if err_return
is set. Same with `while` -- it would return from the function at the
end of iteration. 5.4 is still very popular.
My solution for the performance problem is to call `emulate -L zsh`
only at the points of entry (public API) and then avoid calling too
many small functions.
Roman.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author