Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] _make: target: handle "make -C dir"

Daniel Hahler wrote on Thu, Aug 22, 2019 at 08:37:53 +0200:
> `$basedir` defaults to `$PWD`, so it is ok to pass it always (I assume).

If the current working directory has been deleted, «$PWD» and «./» may refer to
different directories.

> -          _make-parseMakefile < <(_call_program targets "$words[1]" -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null)
> +          _make-parseMakefile < <(_call_program targets "$words[1]" -C $basedir -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null)

Should be «${(q)basedir}», I presume?

Preexisting issue: the other two parameter expansions should probably
use the «${(q)}» syntax too.

Preexisting issue: the last line of _make-findBasedir should use «print
-r», or better yet, assign to REPLY.
Messages sorted by: Reverse Date, Date, Thread, Author