Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
[PATCH] _make: use --always-make instead of .PHONY for GNU make
- X-seq: zsh-workers 44722
- From: Daniel Hahler <genml+zsh-workers@xxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: [PATCH] _make: use --always-make instead of .PHONY for GNU make
- Date: Mon, 2 Sep 2019 11:58:16 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thequod.de; h= content-transfer-encoding:content-type:content-type:mime-version :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=postfix2; t=1567418298; bh=EFJGcG Upp9MAZyUI4w79DBsa0jnitRJA+tiAhXcDqvM=; b=jTMKo35SUtm2jrjKyNMh1k i2brrUn/9SEsBFL0QO2VxxBYTLbFlz09w0Gk34Pz81FZBJAw0Giw7KlPoB9pVtUt kXDOE3vN+CPv5I8bq0nRD3wtEg7TdnRJC8AavF0sWnQjh4EsPGKH0o+xTZ0HLtB4 6BaZgSGaw5koUJS8mR2f0=
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
From: Daniel Hahler <git@xxxxxxxxxx>
Using ".PHONY" might actually execute (phony) targets then, while
"--always-make" triggers processing of all targets, respecting `-n`
(`--dry-run`).
(This can be seen with `make -nsp .PHONY` in
https://github.com/neomake/neomake/tree/76b110d49a, where it actually
causes infinite processing then)
".PHONY" was used since the beginning here (37012f06a [1]).
As for bmake (which also uses `.PHONY`): there does not appear to be a
similar option for it.
While it might work better there (i.e. not causing targets to be run),
it causes an error at least when testing it quickly - which indicates
that it behaves as if using any other non-existing (or special) target
there maybe:
> bmake: don't know how to make .PHONY. Stop
This was added in ecc0a5ece [2] (workers-39654).
Since it uses `-s -f "$file" -V.ALLTARGETS` with `bmake` before to get
targets explicitly, there might not be a reason for calling `bmake` with
`-nsdg1Fstdout … .PHONY` additionally in the first place?!
1: https://github.com/danielshahaf/zsh/commit/37012f06a
2: https://github.com/danielshahaf/zsh/commit/ecc0a5ece
---
Completion/Unix/Command/_make | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Completion/Unix/Command/_make b/Completion/Unix/Command/_make
index e23906373..56d47f4ea 100644
--- a/Completion/Unix/Command/_make
+++ b/Completion/Unix/Command/_make
@@ -262,7 +262,7 @@ _make() {
if [[ $is_gnu == gnu ]]
then
if zstyle -t ":completion:${curcontext}:targets" call-command; then
- _make-parseMakefile < <(_call_program targets "$words[1]" -nsp --no-print-directory -f "$file" .PHONY 2> /dev/null)
+ _make-parseMakefile < <(_call_program targets "$words[1]" -nsp --no-print-directory -f "$file" --always-make 2> /dev/null)
else
_make-parseMakefile < $file
fi
--
2.23.0
Messages sorted by:
Reverse Date,
Date,
Thread,
Author