Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Completion for aplay from alsa-utils
- X-seq: zsh-workers 44890
- From: dana <dana@xxxxxxx>
- To: Sebastian Gniazdowski <sgniazdowski@xxxxxxxxx>
- Subject: Re: Completion for aplay from alsa-utils
- Date: Sun, 3 Nov 2019 17:17:52 -0600
- Cc: Zsh hackers list <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cu90P1pnUmTElIp9ltJzwd3yOqti3bQXlF42D/kpI+Q=; b=bmbLxNsA23Cc9zi2dKuNhaQ1f9msG+/P/0u3HPCABlTt55usCZlXvwx9EF7dlg2nfq deiIrAgMYPe1028+gocK0d8b5z3saXsI1zSEr9yulRfIdqRsrhyGgSM+fmxYDZFXt6T0 lqmj/QeHAZyRasWhXUs4ZfphHXaoME8WG6AA/w3QLUZTDGJkyt59Ikk65K3x1DK6mb8f AYgta/oLASsNqDWx1YNbyaWM7pdyGaNF06zr3N4iavCbfYSgxeLMfCpY/VzyxNXoYrV1 NCpuLlKlprvqmqmId3pKhg/MW2ufRiiBea3WfnDhSAPSDqfbIbjBdRQFWODsmpBAllBT d2Sw==
- In-reply-to: <CAKc7PVArm7cgptJrBaHhe0R=J5M9m8MeiCqLGESN3nu6TdW8bQ@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CAKc7PVArm7cgptJrBaHhe0R=J5M9m8MeiCqLGESN3nu6TdW8bQ@mail.gmail.com>
On 2 Nov 2019, at 16:13, Sebastian Gniazdowski <sgniazdowski@xxxxxxxxx> wrote:
> the submitted completion is in file _alsa-utils
Feels like maybe it should just be called _aplay, unless you think there would
be so much shared code between future alsa-utils completion functions that
they all need to live together in one (not sure but doesn't seem like it)
And you can add arecord to #compdef, since it's basically the same thing as
aplay
Some functional issues i noticed:
* _arguments should have -S
* There are no exclusions for any of the alias options (e.g., -D and --device
should be exclusive)
* --device, --file-type, and --process-id-file should take arguments
* All short aliases of long options that take an argument should have + (e.g.,
-c+ for --channels=)
* -v is cumulative, but there is no * in the spec
Would also be nice to have better optarg completion (there are no argument
descriptions, some of the options take pre-defined arguments that are listed
in the documentation that you could offer, &c.), and taking the option
descriptions from the help output verbatim doesn't look that nice here, but
i'm probably being too pedantic now
dana
Messages sorted by:
Reverse Date,
Date,
Thread,
Author