Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [BUG] Crash when accessing WIDGETSTYLE from SIGINT trap



On 11/11/19, Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx> wrote:
> On Mon, Nov 11, 2019 at 3:58 PM Peter Stephenson
> <p.stephenson@xxxxxxxxxxx> wrote:
>>
>> On Mon, 2019-11-11 at 15:38 +0100, Roman Perepelitsa wrote:
>> > Crash at zle_params.c:436 due to bindk being null:
>> >
>> >     Widget widget = bindk->widget;
>>
>> Looks to me like returning the empty string in that case would be fine?
>
> I don't know. I haven't sent a patch because I'm not sure whether the
> fix should be right there in get_widgetstyle or somewhere earlier so
> that bindk is not null to begin with.
>
> I should've explained what I'm trying to do. I want to use a long
> prompt for the current command line and a short prompt for complete
> commands. Sort of like transient_rprompt option but instead of hiding
> just right prompt I want to hide most of left prompt too. Here's a
> short demo:
> https://raw.githubusercontent.com/romkatv/powerlevel10k-media/master/transient-prompt.gif.
>
> Here's how I'm doing it:
>
> - Set long prompt in precmd.
> - Set short prompt in zle-line-finish and on SIGINT.
>
> The code:
>
>     set-long-prompt() { PROMPT='%~%# ' }
>     precmd_functions=(set-long-prompt)
>
>     set-short-prompt() {
>       if [[ $PROMPT != '%# ' ]]; then
>         PROMPT='%# '
>         zle .reset-prompt
>       fi
>     }
>
>     zle-line-finish() { set-short-prompt }
>     zle -N zle-line-finish
>
>     trap 'set-short-prompt; return 130' INT
>
> One issue with this code is that after hitting Ctrl-C, set-long-prompt
> doesn't get called, so I end up with a short current prompt.

Have you tried restoring the long prompt in zle-line-init instead?

-- 
Mikael Magnusson



Messages sorted by: Reverse Date, Date, Thread, Author