Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 2/3] vcs_info/cvs: set vcs_comm[basedir] in VCS_INFO_detect_cvs

Aleksandr Mezin wrote on Sun, Nov 24, 2019 at 04:14:42 +0600:
> +++ b/Functions/VCS_Info/Backends/VCS_INFO_get_data_cvs
> @@ -5,11 +5,7 @@
> -cvsbase="."
> -while [[ -d "${cvsbase}/../CVS" ]]; do
> -    cvsbase="${cvsbase}/.."
> -done
> +++ b/Functions/VCS_Info/Backends/VCS_INFO_detect_cvs
> @@ -7,5 +7,12 @@ setopt localoptions NO_shwordsplit
> +local cvsbase="."
> +while [[ -d "${cvsbase}/../CVS" ]]; do
> +    cvsbase="${cvsbase}/.."
> +done

I know you just moved this code around, but I'd like to point out that it
causes an infinite loop when /CVS exists.

Cheers,

Daniel
Messages sorted by: Reverse Date, Date, Thread, Author