Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 2/3] vcs_info/cvs: set vcs_comm[basedir] in VCS_INFO_detect_cvs

Daniel Shahaf wrote on Fri, Nov 29, 2019 at 20:30:52 +0000:
> In the meantime, the first two patches in this series can be applied,
> can't they?  Or were you planning to revise and resubmit the CVS one to
> address the (preëxisting) infinite loop?  The first two patches should
> cause no behaviour change, I assume, other than making $hook_com[basedir]
> available to hooks earlier.  Actually, should we document $hook_com[basedir]
> in the manual?

Never mind, I misread the code: it's $vcs_comm[basedir], not
$hook_com[basedir].  The former is only used for communicating between
a VCS_INFO_detect_${vcs} function that uses VCS_INFO_bydir_detect and the
corresponding VCS_INFO_get_data_${vcs} function.

Incidentally, VCS_INFO_detect_cvs should probably use VCS_INFO_bydir_detect.

Cheers,

Daniel
Messages sorted by: Reverse Date, Date, Thread, Author