Re: TR : Re : [BUG] Crash due to malloc call in signal handler

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Peter Stephenson wrote on Sun, Dec 15, 2019 at 19:06:43 +0000:
> On Sat, 2019-12-14 at 12:32 +0000, Peter Stephenson wrote:
> > On Fri, 2019-12-13 at 21:08 +0000, Peter Stephenson wrote:
> > > On Fri, 2019-12-13 at 17:30 +0000, Peter Stephenson wrote:
> > > > I think the intention here is to make sure we're not blocking for a long
> > > > time in this function, but if fgetc() is doing memory allocation we're
> > > > going to have to put that in the signal blocking.  However, if the input
> > > > itself blocks in fgetc() that's going to be a problem.  The fix might be
> > > > not to fdopen() the input file, but just read into a buffer with
> > > > read().
> > > 
> > > This would look like the following, which is passing tests...
> > 
> > Slight update to close the file descriptor and to document the arguments
> > of the function.
> 
> I've committed this --- and as it's potentially serious we should let it
> get a bit of testing and then get it into the release --- but as I've
> still had no comments further examination is still welcome.

I'm installing it as my day-to-day shell right now.

Does this warrant a 5.7.1-test-2 before 5.8?