Re: [PATCH] Completion for sbuild

[Oliver Kiddle <okiddle@xxxxxxxxxxx>]

On 10 Dec, Baptiste BEAUPLAT wrote:
> Thanks a lot for taking the time to review this patch, that greatly
> appreciated. I'll try to fix as much as I can do.

I don't know if Daniel had any further comments on this but it looked
good to me so I've merged it with a couple of very minor tweaks.
Anything else can always be handled with patches.

> +        if [[ -n "${DEBFULLNAME}" ]]; then
> +            identity = "${DEBFULLNAME} <${DEBEMAIL}>"
> +        else
> +            identity = "${DEBEMAIL}"
> +        fi

I removed the spaces either side of the = in these assignments as this
will attempt to run an `identity' command instead.

Thanks for the contribution and for taking the time to go over the
feedback and revise it.

Oliver