Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Improve _man file-path completion

X-seq: zsh-workers 45230
From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: Re: [PATCH] Improve _man file-path completion
Date: Sat, 4 Jan 2020 12:46:30 +0000
In-reply-to: <07B00625-9EC2-454E-B3E0-6F520DE4A899@dana.is>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <83C0ABA0-99A5-4DAD-98D6-DBB919F61E24@dana.is> <20200104003913.3gq5hnlmhndwbzz4@tarpaulin.shahaf.local2> <07B00625-9EC2-454E-B3E0-6F520DE4A899@dana.is>

dana wrote on Fri, Jan 03, 2020 at 19:17:56 -0600:
> How about something like the following, then?

+1, thanks.

> On 3 Jan 2020, at 18:39, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > Aside:
> >
> >    % compdef _f f
> >    % _f() _files -/
> >    % f Util/<TAB>
> > .
> > offers files, rather than nothing.  Bug?
> 
> I seem to recall this being discussed before, and it isn't really a bug, but
> we could change it if we decided to. Someone was complaining about it on IRC
> just the other day. I think we'd simply need to remove *:all-files from
> pats=(...)

Well, it seems like a bug to me, given that -/ "specifies that only directories
should be completed".  If the completion function had wanted files to be
offered, it wouldn't have passed -/ in the first place.

*shrug*

References:
- [PATCH] Improve _man file-path completion
  - From: dana
- Re: [PATCH] Improve _man file-path completion
  - From: Daniel Shahaf
- Re: [PATCH] Improve _man file-path completion
  - From: dana

Messages sorted by: Reverse Date, Date, Thread, Author