Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Make --disable-multibyte warn, since the test suite fails in that configuration. (was: Re: Test failures in --disable-multibyte)



On Fri, 2020-01-03 at 20:11 +0000, Daniel Shahaf wrote:
> Here's a draft.  Probably needs wordsmithing.

Sorry to be slow --- Definitely in the target area; I'm wondering about

> +    # Some requisite functions are missing.
> +    AC_MSG_WARN([Multibyte support disabled due to missing functions: $zfuncs_absent])
> +    AC_MSG_WARN([Building without multibyte support is strongly discouraged and may cause errors in 'make test'.])

where the user doesn't have a lot of choice about what they're building,
so discouraging it is a bit pointless.  I'd be tempted to omit that bit
here.

pws



Messages sorted by: Reverse Date, Date, Thread, Author