Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: draw prompt on the correct line after window change
- X-seq: zsh-workers 45258
- From: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>
- To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- Subject: Re: PATCH: draw prompt on the correct line after window change
- Date: Mon, 6 Jan 2020 20:38:31 +0100
- Cc: Sebastian Gniazdowski <sgniazdowski@xxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
- In-reply-to: <CAH+w=7ahPsMBEEXm-mgQnQpA6tnCpZzL77njcnqk72dkGzARJA@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CAN=4vMp+E7esA48bEtRs-+Rmm9ng7i+FayGVqcLZqyjwVkayAw@mail.gmail.com> <CAKc7PVBEBDvmoxPNgPJUHK8wn2U-9cSNcdr0ADTumV_pu_D2Ww@mail.gmail.com> <CAN=4vMpWxg_-OLRSOYu+JcAnpuvdUp+k+7HVtPH9sXtEFiVh8g@mail.gmail.com> <CAKc7PVCBoLWhNMVdQGmmgFB_zaObo2Ga=YU21yWJC-6KZ+EsHQ@mail.gmail.com> <CAN=4vMpw1EEQHyhx2dAVN8cZ78SMy6-xmWFM1tRX8TDtsTN-fw@mail.gmail.com> <CAKc7PVB1Zmhv6JsLzVVUgSr6Yzyt8O9+Zr7tg3RUS1NfTkY+Mg@mail.gmail.com> <CAH+w=7ahPsMBEEXm-mgQnQpA6tnCpZzL77njcnqk72dkGzARJA@mail.gmail.com>
On Mon, Jan 6, 2020 at 8:28 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> IIR the problem correctly, a possible approach to resolve my concern would be to have the terminal report the cursor position for the shell to read+save it, rather than rely on the terminal save/restore action.
I implemented this prior to the patch I sent. Unfortunately, this
added enough prompt latency to make it noticeable. I suppose some
users might value correct WINCH behavior above fast prompt but I'm not
one of them. When I switched to save/restore cursor, I haven't looked
back. It looks to me like a strict improvement over the current state.
I think it doesn't break or slow anything down, while at the same time
it fixes WINCH handling in most cases (not in all cases though, see my
original email). I might be wrong, and there might be code that gets
broken. If you know any code that might be broken by my patch due to
its use of save/restore cursor, please point me to it and I'll test
my patch against it.
Roman.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author