Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] A glob with a trailing slash will now match unreadable/unexecutable directories.



Peter Stephenson wrote on Mon, 13 Jan 2020 09:46 +00:00:
> On Mon, 2020-01-13 at 00:27 +0000, Daniel Shahaf wrote:
> > ---
> > This fixes the issue, but I'd appreciate some review.
> > 
> > There are some code flow changes, but the basic idea is that instead of
> > changing "foo/" to "foo/." and calling access(), just leave it as-is and
> > call stat() and S_ISDIR() instead.
> 
> Looks like that should do the trick --- next step may be to try it out
> and see if any odd edge cases turn up.
> 
> Not clear if it's needed in the release since it's not a new issue.

My thoughts exactly; I'll commit to the 5.9 branch.  Thanks for the review.



Messages sorted by: Reverse Date, Date, Thread, Author