Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec



Daniel Shahaf writes:
I understand, but I'm not convinced:

1. zsh's test suite aborts a test file as soon as any test group
fails.  Thus, if the bug regresses, the URG test will run but the TERM
test won't.

Ah! Ok, I thought I saw that behaviour before but didn't think too much about it. In which case yes, it's still valuable.

2. The URG test may be copied and adapted.

3. The reasons for picking URG are of interest to anyone who reads the
code (for whatever reason), even if few people will do so.

Cool, you've convinced me. I'll put up a small patch.

Thanks!

Chris



Messages sorted by: Reverse Date, Date, Thread, Author