Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin

[Mikael Magnusson <mikachu@xxxxxxxxx>]

On 2/27/20, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> Jun T wrote on Tue, 25 Feb 2020 18:38 +0900:

> A couple of minor issues spotted in read-through:
>
>> --- a/Src/Builtins/rlimits.c
>> +++ b/Src/Builtins/rlimits.c
>> @@ -53,11 +40,214 @@ enum {
>> +typedef struct {
>
> Suggest to name the struct type — «typedef struct resinfo_t { … }
> resinfo_t» — as that tends to result in prettier output in the debugger.
>
>> +/* table of known resources */
>> +static resinfo_t known_resources[] = {

It shouldn't be named anything_t at all, that suffix is reserved (see
for example the system rlim_t type in the same file). Ref:
https://www.gnu.org/software/libc/manual/html_node/Reserved-Names.html

-- 
Mikael Magnusson