Re: Test Failure. 2020-03-08

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Vin Shelton wrote on Sun, Mar 08, 2020 at 08:38:53 -0400:
> Using the latest sources, I'm getting the following test error in the
> modload test:
> 
> --- /tmp/zsh.ztst.7939/ztst.err 2020-03-08 08:33:41.076674463 -0400
> +++ /tmp/zsh.ztst.7939/ztst.terr 2020-03-08 08:33:41.080007796 -0400
> @@ -0,0 +1 @@
> +zsh:2: failed to load module `zsh/parameter':
> /opt/zsh-2020-03-08/lib/zsh/5.8.0.1-dev/zsh/parameter.so: cannot open shared object file: No such file or directory
> Test ../../../src/zsh-2020-03-08/Test/V01zmodload.ztst failed: error output differs from expected as shown above for:
>  $ZTST_testdir/../Src/zsh -fc '
>    zmodload zsh/parameter
>    unset options
>    echo $+options
>  '
> Was testing: can unset a non-readonly autoloadable parameter after loading
> the module
> ../../../src/zsh-2020-03-08/Test/V01zmodload.ztst: test failed.
> 
> Please let me know if you need more info.

Could you try the following, please?

diff --git a/Test/V01zmodload.ztst b/Test/V01zmodload.ztst
index c3c64a79d..4fddb0bcc 100644
--- a/Test/V01zmodload.ztst
+++ b/Test/V01zmodload.ztst
@@ -349,6 +349,7 @@
 ?(eval):9: file descriptor out of range
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    if zmodload -e zsh/parameter; then zmodload -u zsh/parameter; fi
    unset options
    zmodload zsh/parameter
@@ -359,6 +360,7 @@
 # Currently prints '1'.
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    zmodload zsh/parameter
    unset options
    echo $+options
@@ -367,6 +369,7 @@
 >0
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    if zmodload -e zsh/parameter; then zmodload -u zsh/parameter; fi
    unset builtins
  '
@@ -375,13 +378,15 @@
 # Currently, the 'unset' succeeds.
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    zmodload zsh/parameter
    unset builtins
  '
 1:can't unset a readonly autoloadable parameter after loading the module
-?zsh:3: read-only variable: builtins
+*?zsh:?: read-only variable: builtins
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    zmodload zsh/parameter
    zmodload -u zsh/parameter
    echo $options

Cheers,

Daniel