Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin



> 2020/03/23 14:41, I wrote:
> 
> Personally I feel only adding a test (B12limit.zsh) is enough for now, but
> have no objection to adding a runtime check in rlimits.c.

If I add the runtime check, and if there is a duplicated option letter,
I get the error message 'duplicate ulimit option letter' every time
I start zsh. This may be quite annoying for ordinary users.

B12limit.ztst (limit| grep UNKNOWN || print OK) fails due to the error
message; I think it's OK. But V01zmodload.ztst also fails due to the
message, and other tests would fail if they use the rlimits module.

So I think just adding a test for duplicated option letter is enough.
If someone add a new resource then it is their responsibility to
confirm that all the tests pass. I think ordinary users need not see
the error message.



Messages sorted by: Reverse Date, Date, Thread, Author