Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Feature request: ZSH_XTRACEFD variable
- X-seq: zsh-workers 45776
- From: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: Feature request: ZSH_XTRACEFD variable
- Date: Mon, 4 May 2020 09:26:32 +0100 (BST)
- Importance: Medium
- In-reply-to: <20200503212325.2fda9b66@tarpaulin.shahaf.local2>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <EL9xNuAdKSLWp41th3XxhRLVtul7jHkT9ons2s2c_35aNjCbCMzo4DqiCNV1SoNjdLhNgdUGLNMHQxQ9q4jDMcNIsxzonWx5jzOB5Hr8rBs=@protonmail.com> <20190518075514.hbygmb5dl5wz23h5@chaz.gmail.com> <20190520103444.qyih7lvoigvf3rfx@chaz.gmail.com> <CGME20190721150914epcas1p18b5b4b9ccc4e593e854b076a835257c7@epcas1p1.samsung.com> <CAD8ZDTrfrWTKfa1efTo63uk1XJO4BOp5hSLOfjL1tXkeDMf_QQ@mail.gmail.com> <1563722540.4311.24.camel@samsung.com> <CAD8ZDTokqOTfEajquX2SKU5pLWgd85sPdRMYkxE4nF0pQhi+BA@mail.gmail.com> <1565710707.5633.11.camel@samsung.com> <CAD8ZDTotCLBANtzppSbCcgKyLhkXaVWysjqv99xS6bnLypBViA@mail.gmail.com> <309829031.4459446.1587391766024@mail2.virginmedia.com> <CAD8ZDTp=rYsWiEkq3byjU=BRAA2iLwxt5QG_19MBc+Jo8dC-0w@mail.gmail.com> <e6f0ff4189cdd742b319ff2596e2ae083ac52e8e.camel@ntlworld.com> <20200503212325.2fda9b66@tarpaulin.shahaf.local2>
> On 03 May 2020 at 22:23 Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
>
>
> Peter Stephenson wrote on Sun, 03 May 2020 18:30 +0100:
> > On Sat, 2020-05-02 at 20:02 +0200, Timothée Mazzucotelli wrote:
> > > I wrote such a test and noticed that file descriptors were being
> > > closed each time ZSH_XTRACEFD was (re)assigned, even as a local
> > > variable. So I removed the code lines closing the previous file
> > > descriptor in xtracefdsetfn, and it seemed to work well.
> >
> > This re-introduces the file descriptor leak I was at pains to remove.
> > It apparently works because the test isn't sensitive to the leak ---
> > that's hard to fix in a standard way, i.e. with1out having some limit you
> > can rely on on file descriptors being created.
> >
>
> Which test is that?
I'm thinking of 45760, but actually it's explicitly testing for closed file
descriptors (rather than looking for a leak), so that should be on the
right lines. I'll look a bit more closely to check what's going on when
I get a chance --- I'm evidently missing aspects of how this fits together
anyway.
pws
Messages sorted by:
Reverse Date,
Date,
Thread,
Author