Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: local_traps doesn't restore traps set from functions
- X-seq: zsh-workers 45792
- From: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>
- To: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- Subject: Re: local_traps doesn't restore traps set from functions
- Date: Fri, 8 May 2020 08:51:16 +0200
- Cc: Zsh hackers list <zsh-workers@xxxxxxx>
- In-reply-to: <20200507212136.3ff1a843@tarpaulin.shahaf.local2>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CAN=4vMrq8S=W+C8Vcp_pZGkc0eNymK3d+x0E3yib6BHu5ZRhDg@mail.gmail.com> <20200507212136.3ff1a843@tarpaulin.shahaf.local2>
On Thu, May 7, 2020 at 11:21 PM Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
>
> The following patch fixes it:
Thanks for the patch. I confirm that it works. I've tried a handful of
different combinations of traps and all work as expected.
One stylistic suggestion for the patch: replace sigtrapped[i] fixup with this:
sigtrapped[i] -= 1 << ZSIG_SHIFT;
It'll align the code with the preceding comment to the point of making
the comment superfluous. I also find it easier to understand although
that may be subjective.
Roman.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author