Re: 'make install' fails when build directory is differnet from that of source tree.

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Yasuhiro KIMURA wrote on Sat, 30 May 2020 18:05 +0900:
> [Similar problem with help files]
> 
> Similar problem happens with 'make install.runhelp' when build is
> out-of-source and source is from tarball.
> 
> cd /tmp/zsh/source
> tar xfpvJ /somewhere/zsh-5.8.tar.xz
> cd /tmp/zsh/build
> /tmp/zsh/source/zsh-5.8/configure --srcdir=/tmp/zsh/source/zsh-5.8
> make DESTDIR=/tmp/zsh/install install.runhelp
> 
> These steps result in following error.
> 
> make[1]: Entering directory '/tmp/zsh/build/Doc'
> if test x"/usr/local/share/zsh/5.8/help" != x""; then \
>     /bin/sh /tmp/zsh/source/zsh-5.8/mkinstalldirs /tmp/zsh/install/usr/local/share/zsh/5.8/help; \
>     /bin/install -c -m 644 help/* /tmp/zsh/install/usr/local/share/zsh/5.8/help; \
>     while read from to; do \
>         rm -f /tmp/zsh/install/usr/local/share/zsh/5.8/help/$to || : ; \
>         ln -s $from /tmp/zsh/install/usr/local/share/zsh/5.8/help/$to; \
>     done < help.txt; \
> fi
> /bin/install: cannot stat 'help/*': No such file or directory
> /bin/sh: 4: cannot open help.txt: No such file
> make[1]: *** [Makefile:482: install.runhelp] Error 2
> make[1]: Leaving directory '/tmp/zsh/build/Doc'
> make: *** [Makefile:226: install.runhelp] Error 2
> 

Thanks for the report.

This looks like another effect of the same series of Doc/Makefile.in commits:

    76a16498d 43692: Generate man pages in the build dir, rather than the source dir.
    b2ddd9717 43404 (after 43392): Fix 'make install' in out-of-tree builds
    85ae84e89 43392: dist: Generate doc/help/* and doc/help.txt in builddir rather than srcdir.

For me, the patch I just posted (the second revision, from today) fixes
this issue as well.  I also confirmed that `cd $DESTDIR/$prefix/share/zsh/5.8/help && find`
and `cd /usr/share/zsh/help && find` [the latter being my distro's
build] produce identical outputs.

Do let us know if anything else seems amiss.

Cheers,

Daniel

> Best Regards.
> 
> ---
> Yasuhiro KIMURA