Re: [PATCH v2] exec: run final pipeline command in a subshell in sh mode

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Peter Stephenson wrote on Sun, 07 Jun 2020 18:24 +0100:
> On Sun, 2020-06-07 at 09:55 -0700, Bart Schaefer wrote:
> > On Fri, Jun 5, 2020 at 1:42 PM brian m. carlson
> > <sandals@xxxxxxxxxxxxxxxxxxxx> wrote:  
> > > 
> > > I will tell you that as a practical matter, nobody writing code for sh
> > > expects the last command not to be run in a subshell and consequently
> > > lots of code is practically broken in this case with zsh as /bin/sh.  
> > 
> > I believe you, but would be curious to see an example.
> > 
> > For what it's worth, I'm not opposed to this patch.  I think it's
> > pretty unlikely that anyone is invoking zsh as sh and still expecting
> > to be able to (for example) pipe into read to set variables in the
> > current shell.  
> 
> Yes, since I'm still here, that's my position too.
> 
> Our general position on consistency is that we'll try our best to
> keep native mode compatible, while with sh compatibility we'll
> try to be like other shells and not worry so much about what zsh
> used to do.

This being the case, I'm happy to defer to consensus.  I won't object
to an entry in the list of incompatibilities in README, though.

I can't speak for Mikael, of course.

> But it's a little bit of an odd case here for all the reasons I won't
> rehash.

Thanks for the additional context,

Daniel