Re: [PATCH] add missing read-only zfs property "space"

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Thanks for the patch.

I see that «zfs list -o space» works, but I don't see any reference to
the value «space» in the help output (`zfs list -o foobar 2>&1`) or man
page.  Is that value supported and undocumented?  Or is it undocumented
because it's deprecated?

workers@, could someone take over the review, please?  I have a few
patches to finish and don't want to spread myself too thin.

Cheers,

Daniel


Frederick Zhang wrote on Fri, 05 Jun 2020 18:11 +1000:
> Signed-off-by: Frederick Zhang <frederick888@xxxxxxxxxxxx>
> ---
>  Completion/Unix/Command/_zfs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Although it's only documented under 'zfs list', it seems to be available
> to other subcommands as well, e.g. 'zfs get'.
> 
> diff --git a/Completion/Unix/Command/_zfs b/Completion/Unix/Command/_zfs
> index 814358bc7..452e1160d 100644
> --- a/Completion/Unix/Command/_zfs
> +++ b/Completion/Unix/Command/_zfs
> @@ -132,9 +132,9 @@ _zfs() {
>  	)
>  
>  	# TODO: userused@ and groupused@ could have more extensive handling
>  	ro_properties=(
> -		"name" "type" "creation" "used" "available" "referenced"
> +		"name" "type" "creation" "space" "used" "available" "referenced"
>  		"compressratio" "mounted" "origin" "usedbychildren"
>  		"usedbydataset" "usedbyrefreservation" "usedbysnapshots"
>  		"defer_destroy" "userused@" "userrefs" "groupused@"
>  		"keychangedate" "keystatus" "rekeydate"