Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: region_highlight converts `fg=default` to `none`, which is not the same
- X-seq: zsh-workers 47456
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>
- Subject: Re: region_highlight converts `fg=default` to `none`, which is not the same
- Date: Wed, 14 Oct 2020 20:46:21 +0000
- Archived-at: <https://zsh.org/workers/47456>
- Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2020-10/20201014204621.4cf5b2b0%40tarpaulin.shahaf.local2>
- Authentication-results: zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none
- Cc: Marlon Richert <marlon.richert@xxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-type :content-transfer-encoding; s=fm1; bh=CgT35fl0EbMdJ6Q1/gCiD0X0K1 1ZTheJwMCvQi1eRLU=; b=Bp4qB9Fb9iBJvdRHl6Rt7BGY1LoabPIoG/RFk+Y6oK i8IXMKRq1ykFjrxitTXzGA++11yojOoFkWXX+3+88mNLdIBA53QmWNS4ukz8fPMn HUjQuejDO/U0wROzMgPt2L2BZz0MGJKBqtzUzPY8KkuDosILioQe6JrXFL/SpMps /rFENKDAy5xU39V1AucOcIpGNbXKT/F+RwjGK0zTDVUwQ8jDdrrq8Bs8mm/TMDaB ghgImCL7Y5828nseu1PQczQVh0QRKZZWCcLB0sVxTzgTGqW0OKdTbdm97zPM7Ca7 rH4vz1fE5l+2zTzXcn0ATjNX6wE0ebUfscJMqJpNngiw==
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=CgT35fl0EbMdJ6Q1/gCiD0X0K11ZTheJwMCvQi1eR LU=; b=BLglsq2J5fA/ZHszjNjSqsa9MkQTXevYVfzzM7Cj9FeXrs4FCWfGqtCnU Mo1B1hux7HQqpBW0ufVzXd7j6pEH+932JqqdeN0ML3CEPaXji0G5EM5c4Chnnqu4 pJm4fdTCe5ys8GJ4Tm5CflRRjjXkfK+5c5V+Qs6wGLYZEfcEFV4MRDW/D/2IDLMN 9lMDB5mIcIBaBrkdS5BMEVzcoXcsFO7xiJJHDSmRHn4LB9w/XAZ/uH1fn9i1PmSV R49PY/4oKQ35QkmGpdFCa400otb2U/ER9ore+DFo/qx7oNerldiW/377Eik+SYXG /I56/WL5CmtUsfAw36Ke8EhTknchA==
- In-reply-to: <CAN=4vMq1CjLKiwM0_HWfQf5=xLTGQ7z9mVs=QEsCp05suLK-fA@mail.gmail.com>
- List-archive: <http://www.zsh.org/sympa/arc/zsh-workers>
- List-help: <mailto:sympa@zsh.org?subject=help>
- List-id: <zsh-workers.zsh.org>
- List-owner: <mailto:zsh-workers-request@zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-subscribe: <mailto:sympa@zsh.org?subject=subscribe%20zsh-workers>
- List-unsubscribe: <mailto:sympa@zsh.org?subject=unsubscribe%20zsh-workers>
- References: <CAHLkEDv9ch+nhtpYF3So+029J6GMv5iU-8=RzHRHLa7OYzc3kg@mail.gmail.com> <CAN=4vMq1CjLKiwM0_HWfQf5=xLTGQ7z9mVs=QEsCp05suLK-fA@mail.gmail.com>
- Sender: zsh-workers-request@xxxxxxx
Roman Perepelitsa wrote on Tue, 13 Oct 2020 13:05 +0200:
> On Mon, Oct 12, 2020 at 11:23 AM Marlon Richert
> <marlon.richert@xxxxxxxxx> wrote:
> >
> > 1. It seems incorrect to convert `fg=default` to `none`. From reading the [documentation](http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting), `none` is not supposed to be the same as `fg=default`.
>
> I took a quick look at this yesterday. When you print region_highlight
> and "fg=default" comes out as "none", that's a bug in the printing
> logic (function output_highlight in Src/prompt.c). It's fairly easy to
> fix -- patch below (only for fg; bg should be handled similarly).
> Naturally, it doesn't solve the other issues you've described. I
> haven't looked at why the highlight doesn't get applied as it should
> be.
z-sy-h does «region_highlight_copy=("${region_highlight[@]}"); …
region_highlight=("${region_highlight_copy[@]}");» around invoking
a highlighter, so the serialization bug could explain the observed ZLE
behaviour, couldn't it?
> Roman.
>
> P.S.
>
> zsh-workers is the correct mailing list for this discussion.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author