Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [patch] Avoid race in zf_mkdir
- X-seq: zsh-workers 47460
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>
- Subject: Re: [patch] Avoid race in zf_mkdir
- Date: Thu, 15 Oct 2020 08:29:02 -0700
- Archived-at: <https://zsh.org/workers/47460>
- Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2020-10/CAH%2Bw%3D7ZWYjRC8TX0-BekfW932pw_P15YSad03SJaHL8%3D3-S%2BzA%40mail.gmail.com>
- Authentication-results: zsh.org; iprev=pass (mail-oi1-f176.google.com) smtp.remote-ip=209.85.167.176; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none
- Cc: Zsh hackers list <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WHGbAhMs9khwTCc5F1T3/9QfBQgeFLXoXP/qoEoqGgg=; b=c0tAAO5nokdQG4jV3FIJBTTJLvGgtxLCETAOQX8H0ehlwqKWbJofDUf+yqSCoAQ/p7 pp6JgiDUVx9Nw5e8xuS4dFhgGAg93lqk1oIdieqpUoih3ep3L5aIwSBuf5siIudMvbzF qXBPkX7pU2LjfK1enzk7BDjfuFjA2MXcBA4SBipFmUxm922GWiRgX5ZBxmfgsnt6hApB h3xFSX8ZGr6wXipy/ZexPEfTRKvUmETPzgheh0aKeX6DyWTsa/Df35jlrXEdLrV+5ZKW dWSM3vMzRk6GOHE/TjR8GYQ6idZVtFUkIWiFpwfU5E/lEg8bPFDlW5yTXfkijPDFLn1k Cy+g==
- In-reply-to: <CAN=4vMqihCrowyGTxKhkdzOQq3GcmWes3fuzYXJ1DBN9WsLnmA@mail.gmail.com>
- List-archive: <http://www.zsh.org/sympa/arc/zsh-workers>
- List-help: <mailto:sympa@zsh.org?subject=help>
- List-id: <zsh-workers.zsh.org>
- List-owner: <mailto:zsh-workers-request@zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-subscribe: <mailto:sympa@zsh.org?subject=subscribe%20zsh-workers>
- List-unsubscribe: <mailto:sympa@zsh.org?subject=unsubscribe%20zsh-workers>
- References: <20201009200737.GA78914@CptOrmolo.darkstar> <CAH+w=7anY9r+-MYki4cycVuaP2+d9L3W5u8k3sHyZx4R5kvafg@mail.gmail.com> <CAN=4vMoJrD+g4Go37yT6gF-Lx61vHm45GvmG1Fx6-+3yyb1hAQ@mail.gmail.com> <CAH+w=7ZRvW3Yq3XO6TwbK1hgSDNE8ynX0eQOU2dTuLcAELNUDg@mail.gmail.com> <20201009205357.GA6449@CptOrmolo.darkstar> <CAN=4vMqJ8SXkz_EVqwL7-9gCQYg9GMczOztAtsErirXGEDRq8Q@mail.gmail.com> <CAH+w=7ZfkwJY6a1LzR3n=LsOmB21WKUZMXfNzXN1hNDFpdeG2w@mail.gmail.com> <CAN=4vMpuSaF6BDhhUP=tnvDDMTN=iKExkmtb5QgtoeCqN_9D3g@mail.gmail.com> <CAN=4vMqihCrowyGTxKhkdzOQq3GcmWes3fuzYXJ1DBN9WsLnmA@mail.gmail.com>
- Sender: zsh-workers-request@xxxxxxx
On Thu, Oct 15, 2020 at 3:02 AM Roman Perepelitsa
<roman.perepelitsa@xxxxxxxxx> wrote:
>
> Does anyone have an opinion on the value of N? My latest patch sets
> N=8 but N=1 would be fine in practice, too.
Any value > 1 would probably render the chances of an incorrect result
astronomically small.
Minor nits about the patch:
- zsh coding style prefers a space between keywords such as if/while,
and the open paren.
- I'm paranoid about tests like "while (n--)", I prefer "while (n-- > 0)".
Messages sorted by:
Reverse Date,
Date,
Thread,
Author