Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Another push on declarednull branch
- X-seq: zsh-workers 47764
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
- Subject: Another push on declarednull branch
- Date: Sun, 27 Dec 2020 15:04:53 -0800
- Archived-at: <https://zsh.org/workers/47764>
- Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2020-12/CAH%2Bw%3D7ayKmgc3qPWLr8%2BNHLCmmhcQxo%2Bn%3DcAO3pyriTjsNpTQQ%40mail.gmail.com>
- Authentication-results: zsh.org; iprev=pass (mail-ot1-f53.google.com) smtp.remote-ip=209.85.210.53; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none
- Cc: Felipe Contreras <felipe.contreras@xxxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0SRErqvtuaboQZv9hFJM6PBF2p3tV+X14+7E9kmj6CQ=; b=BddM+AjZByjjsBv1r8C959EqFvREnKHxCahiMZJEbVGjq2hic8FtELx/XwsFme6RPX N0LK4ndF3XcGfcypaF+zw1gUnRh/kdb8tfQeFvXJP82h5bK5JKYycSQYRY/tjg6Q4KfS gg3AnKHJvBHE97w428XG6XDvwFZUlqOSsBX4VO53cavCI1cXwxc1zNXIE2Ythiv/Y6oP ZwC0bT4Mom0w+0EgrTxU9CkTG0TduE/VAagQPPHIHp9Ps0bWWHo35zuIObCDBpCywslK OWid72ZLos1XOjRKC55EbZoCXgeSLhNlPSLVdEb37xdqzF79E1Qiq+J8+LSdm5l+BSmS JyHQ==
- In-reply-to: <20201223234711.492603-1-felipe.contreras@gmail.com>
- List-archive: <http://www.zsh.org/sympa/arc/zsh-workers>
- List-help: <mailto:sympa@zsh.org?subject=help>
- List-id: <zsh-workers.zsh.org>
- List-owner: <mailto:zsh-workers-request@zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-subscribe: <mailto:sympa@zsh.org?subject=subscribe%20zsh-workers>
- List-unsubscribe: <mailto:sympa@zsh.org?subject=unsubscribe%20zsh-workers>
- References: <20201223234711.492603-1-felipe.contreras@gmail.com>
- Sender: zsh-workers-request@xxxxxxx
On Wed, Dec 23, 2020 at 3:47 PM Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
>
> In my branch it's actually called PM_NULL because I think semantically
> makes more sense.
Note I'm not rejecting your diff, just fixing things I overlooked in my own.
I OR'd PM_UNSET into PM_DECLAREDNULL because I thought there would be
fewer (and/or less confusing) cases where PM_UNSET had to be ignored
than cases where both PM_UNSET and (new flag) had to be treated as
equivalent, but having found all (hopefully) of the former it's
probably a wash. Maybe you can still generate a simpler patch.
Alternate names for PM_DECLARED would be welcome. If I could turn
back time, I might use PM_NOTSET, and then PM_NULL ==
(PM_NOTSET|PM_UNSET). In fact I already like that enough better that
I'd probably redo it that way before submitting a patch for master.
> I added a test that shows a discrepancy I found (${(t)var})
New push to declarednull branch (tip is now 20e4d07b0) fixes this.
Also added the test from Filipe's patch and another test for readonly
declarations.
Note that workers/47704 (POSIX "readonly -p") hasn't been
committed/pushed anywhere yet, and I don't think we discussed whether
that should do something to "typeset" in ksh emulation.
It may be several days before I can look at this again.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author