Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 1/3] src: fix build warnings

X-seq: zsh-workers 47789
From: Felipe Contreras <felipe.contreras@xxxxxxxxx>
To: Mikael Magnusson <mikachu@xxxxxxxxx>
Cc: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH 1/3] src: fix build warnings
Date: Sat, 2 Jan 2021 12:30:11 -0600
Archived-at: <https://zsh.org/workers/47789>
Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-01/CAMP44s05KAVSWP90NeZ5DnUOSTkKF4eEmFJqHCDxn6ERuG5BjQ%40mail.gmail.com>
In-reply-to: <CAHYJk3QvTvjtvQFRfbn+r9S3f4mBC6Pfef6exG4HSE5BrU9EHg@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <20201231054131.682544-1-felipe.contreras@gmail.com> <20201231054131.682544-2-felipe.contreras@gmail.com> <8591b9d9-f2f0-4045-b8e2-d1b759a360c0@www.fastmail.com> <CAHYJk3QvTvjtvQFRfbn+r9S3f4mBC6Pfef6exG4HSE5BrU9EHg@mail.gmail.com>

On Sat, Jan 2, 2021 at 10:41 AM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:

> If we ever return the address of tmp, bad things are likely to happen
> regardless of the static so hopefully that never happens. Returning
> the address of a local variable basically means it will be junk
> (current hypothetical behavior), whereas returning a static means the
> function wouldn't be re-entrant (hypothetical behavior with the
> patch).

Correct, but one is more proper than the other, and it gets rid of the warning.

The best fix is to allocate one byte, especially if it's going to be
freed later on.

-- 
Felipe Contreras

Follow-Ups:
- Re: [PATCH 1/3] src: fix build warnings
  - From: Daniel Shahaf

References:
- Re: [PATCH 1/3] src: fix build warnings
  - From: Daniel Shahaf
- Re: [PATCH 1/3] src: fix build warnings
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author