Re: [PATCH v3] Make zpty module work in the cygwin and msys2

[Jun T <takimoto-j@xxxxxxxxxxxxxxxxx>]

Thank you for the patch. It (v3) works fine on my Cygwin (3.1.7).

> 2021/01/18 11:28, Peiyuan Song <squallatf@xxxxxxxxx> wrote:
> 
> assume cygwin upstream issue will be fixed in version
> 3.2.0

Are you sure it will be fixed in 3.2.0 (and also not fixed in 3.1.x) ?


Currently, all or part of the following tests are skipped on Cygwin
due to the broken zpty:

E01, V08, W02, X0{2,3,4} Y0{1,2,3}

If these are modified so that they are no skipped on Cygwin, all of them
pass except Y01, which fails as follows:


./Y01completion.ztst: starting.
--- /tmp/zsh.ztst.60503/ztst.out        2021-01-18 10:07:03.427737000 +0900
+++ /tmp/zsh.ztst.60503/ztst.tout       2021-01-18 10:07:03.662082600 +0900
@@ -3,7 +3,7 @@
 FI:{\!foo}
 FI:{\#foo}
 FI:{Afoo}
-FI:{\\foo}
 FI:{bfoo}
+EX:{foo}
 FI:{\|foo}
 FI:{\~foo}
Test ./Y01completion.ztst failed: output differs from expected as shown above for:
  {
    mkdir sortnobslash
    touch sortnobslash/{'!foo','#foo','\foo','|foo','~foo',Afoo,bfoo}
    comptesteval 'old_LC_ALL=$LC_ALL; LC_ALL=C'
    comptest $': sortnobslash/\t'
  } always {
    comptesteval 'LC_ALL=$old_LC_ALL'
    rm -rf sortnobslash
  }
Was testing: ignore backslashes when sorting completion matches
./Y01completion.ztst: test failed.


As you can see, 'sortnobslash/foo' (instead of 'sortnobslash/\foo') is created
by the touch command.
I guess '\' is not allowed in a filename on Cygwin.