Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 2/2] promptinit: Fix prompt cleanups

X-seq: zsh-workers 47871
From: Arseny Maslennikov <ar@xxxxxxxxx>
To: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH 2/2] promptinit: Fix prompt cleanups
Date: Mon, 25 Jan 2021 15:50:12 +0300
Archived-at: <https://zsh.org/workers/47871>
Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-01/YA6%2BhOffLLkMPXfw%40cello>
In-reply-to: <CAN=4vMpsBu++iDpHnp-p22zY8g-UN4LdRe+3BK-5VGrDLvgHAQ@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
Openpgp: url=http://grep.cs.msu.ru/~ar/pgp-key.asc
References: <20210125081625.3193714-1-ar@cs.msu.ru> <20210125081625.3193714-2-ar@cs.msu.ru> <CAN=4vMpsBu++iDpHnp-p22zY8g-UN4LdRe+3BK-5VGrDLvgHAQ@mail.gmail.com>

On Mon, Jan 25, 2021 at 09:23:32AM +0100, Roman Perepelitsa wrote:
> On Mon, Jan 25, 2021 at 9:17 AM Arseny Maslennikov <ar@xxxxxxxxx> wrote:
> >
> > This problem was previously brought up in zsh-users/23314, to no avail.
> 
> Also related: zsh-workers/46202.

Thank you for bringing this up!

However, during working on the patch I found out this is not the only
problem with prompt theme cleanups. prompt_$theme_setup works both as an
autoloaded function to pull the theme components in and as the setup
function, so `prompt -h $theme' and `prompt -p $theme' both _activate_ the
$theme and fail to run the cleanup actions.

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH 1/2] promptinit: typo: RPOMPT -> RPROMPT
  - From: Arseny Maslennikov
- [PATCH 2/2] promptinit: Fix prompt cleanups
  - From: Arseny Maslennikov
- Re: [PATCH 2/2] promptinit: Fix prompt cleanups
  - From: Roman Perepelitsa

Messages sorted by: Reverse Date, Date, Thread, Author