Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [BUG]: zle-line-pre-redraw breaks vi-repeat-change
- X-seq: zsh-workers 47877
- From: "Paul" <GammaFunction@xxxxxxxxxxx>
- To: "Roman Perepelitsa" <roman.perepelitsa@xxxxxxxxx>, "Zsh hackers list" <zsh-workers@xxxxxxx>
- Subject: Re: [BUG]: zle-line-pre-redraw breaks vi-repeat-change
- Date: Tue, 26 Jan 2021 14:55:09 -0600
- Archived-at: <https://zsh.org/workers/47877>
- Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-01/C8TE0S473FV2.14B73I9JO6465%40kbvv>
- Dkim-filter: OpenDKIM Filter v2.11.0 smtp.vivaldi.net B43E6BF665
- Dkim-filter: OpenDKIM Filter v2.11.0 smtp.vivaldi.net 480DBBD02A
- In-reply-to: <CAN=4vMqPA1WAt6_Kj99_PGH+EvOpcK5So3bON5sjBzzmeikeXg@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
On Wed Dec 16, 2020 at 2:33 AM CST, Roman Perepelitsa wrote:
> On Wed, Oct 7, 2020 at 2:49 PM Roman Perepelitsa
> <roman.perepelitsa@xxxxxxxxx> wrote:
> >
> > If zle-line-pre-redraw is defined, vi-repeat-change behaves as if the
> > numeric argument was always 1.
> >
> > To reproduce from `zsh -f`:
> >
> > % function zle-line-pre-redraw() {}
> > % zle -N zle-line-pre-redraw
> > % bindkey -v
> > % 123456<ESC><2X><.>
> >
> > The last line in more detail:
> >
> > - "123456" is self-insert
> > - ESC is vi-cmd-mode
> > - "2X" is vi-backward-delete-char with NUMERIC = 2
> > - "." is vi-repeat-change
> >
> > Expected: BUFFER contains "16".
> >
> > Actual: BUFFER contains "126".
> >
> > The actual behavior is unchanged if <.> is replaced with <3.>. The
> > expected BUFFER in this case is "6".
>
> GammaFunction@xxxxxxxxxxx (CC-ed) has sent
> https://github.com/zsh-users/zsh/pull/69 that fixes the two tests I've
> described above. Here's the patch from the PR.
>
> Roman.
Hey, I just want to bump this, I would like to see this merged soon.
The PR has a second commit which renames some identifiers to be more
consistent, feel free to ignore it.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author